elasticsearch_install broken with v1.0.1

[thomasdziedzic]

elasticsearch_install used to work with v1.0.0 but then it broke for me under v1.0.1 when spinning up a new box:

affected line:
https://github.com/PagerDuty/cookbook-elasticsearch/blob/master/libraries/provider_install.rb#L89

127.0.0.1 ================================================================================
127.0.0.1 Error executing action `install` on resource 'elasticsearch_install[elasticsearch]'
127.0.0.1 ================================================================================
127.0.0.1
127.0.0.1 NoMethodError
so ```elasticsearch_install``` used to work in v1.0.0, I then upgraded to v1.0.1 and I get the following error when spinning up a new box:

127.0.0.1 -------------
127.0.0.1 No resource or method named `include_recipe' for `Chef::Provider::ElasticsearchInstall ""'
127.0.0.1
127.0.0.1 Cookbook Trace:
127.0.0.1 ---------------
127.0.0.1 /var/chef/cache/cookbooks/elasticsearch/libraries/provider_install.rb:89:in `install_tarball_wrapper_action'
127.0.0.1 /var/chef/cache/cookbooks/elasticsearch/libraries/provider_install.rb:13:in `block (2 levels) in <class:ElasticsearchInstall>'
127.0.0.1 /var/chef/cache/cookbooks/elasticsearch/libraries/provider_install.rb:11:in `block in <class:ElasticsearchInstall>'
127.0.0.1
127.0.0.1 Resource Declaration:
127.0.0.1 ---------------------
127.0.0.1 # In /var/chef/cache/cookbooks/pd-elasticsearch/recipes/default.rb
127.0.0.1
127.0.0.1   3: elasticsearch_install 'elasticsearch' do
127.0.0.1   4:   type :tarball
127.0.0.1   5:   version node['pd-elasticsearch']['elasticsearch']['version']
127.0.0.1   6: end
127.0.0.1   7:
127.0.0.1
127.0.0.1 Compiled Resource:
127.0.0.1 ------------------
127.0.0.1 # Declared in /var/chef/cache/cookbooks/pd-elasticsearch/recipes/default.rb:3:in `from_file'
127.0.0.1
127.0.0.1 elasticsearch_install("elasticsearch") do
127.0.0.1   action :install
127.0.0.1   retries 0
127.0.0.1   retry_delay 2
127.0.0.1   default_guard_interpreter :default
127.0.0.1   declared_type :elasticsearch_install
127.0.0.1   cookbook_name "pd-elasticsearch"
127.0.0.1   recipe_name "default"
127.0.0.1   type :tarball
127.0.0.1   version "1.7.2"
127.0.0.1 end

[martinb3]

I'm surprised at this one; I've converged 1.0.1 on multiple platforms with chef 12.4.1 and haven't seen this one. I'm happy to merge your fix, but could you tell me what version of Chef this was affecting?

[martinb3]

Ah, I was able to reproduce this on 12.3.0 but not 12.4.1. Looks like they broke some compatibility in LWRPBase between versions.

[theckman]

This is being used with chef-client 12.1.1.

[theckman]

It might be worth mentioning that I've noticed that 12.4.1 broke compatibility with a few things.

[martinb3]

FWIW, I'm about to release a new version, with testing for 12.1.2, 12.2.1, 12.3.0, as well as 12.4.1. This shouldn't regress in this way again.