Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berks upload fails due to .DS_Store files found in 0.3.12 package on supermarket.chef.io #278

Closed
peterjmit opened this issue Jan 13, 2015 · 4 comments

Comments

@peterjmit
Copy link

Due to berkshelf/ridley#284 berks upload will fail if .DS_store files are found in the package.

When I try to upload my cookbook to our chef server I get the following response

D, [2015-01-13T11:20:37.195213 #74082] DEBUG -- : ** error encounted in Chef response
E, [2015-01-13T11:20:37.196551 #74082] ERROR -- : Ridley::Errors::HTTPBadRequest: {"error":["Invalid element in array value of 'templates'."]}
E, [2015-01-13T11:20:37.196884 #74082] ERROR -- : /Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/middleware/chef_response.rb:24:in `on_complete'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/response.rb:9:in `block in call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/response.rb:57:in `on_complete'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/response.rb:8:in `call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/response.rb:8:in `call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/response.rb:8:in `call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/middleware/chef_auth.rb:74:in `call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/request/retry.rb:87:in `call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/rack_builder.rb:139:in `build_response'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/connection.rb:377:in `run_request'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/connection.rb:106:in `run_request'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/faraday-0.9.0/lib/faraday/connection.rb:177:in `put'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:26:in `public_send'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:26:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:63:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/cell.rb:60:in `block in invoke'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/cell.rb:71:in `block in task'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/actor.rb:357:in `block in task'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/tasks.rb:57:in `block in initialize'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/tasks/task_thread.rb:21:in `block in create'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/thread_handle.rb:13:in `block in initialize'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/actor_system.rb:32:in `block in get_thread'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/internal_pool.rb:130:in `call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/internal_pool.rb:130:in `block in create'
(celluloid):0:in `remote procedure call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:92:in `value'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/proxies/sync_proxy.rb:33:in `method_missing'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/proxies/cell_proxy.rb:17:in `_send_'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/pool_manager.rb:41:in `_send_'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/pool_manager.rb:140:in `method_missing'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:26:in `public_send'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:26:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:63:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/cell.rb:60:in `block in invoke'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/cell.rb:71:in `block in task'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/actor.rb:357:in `block in task'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/tasks.rb:57:in `block in initialize'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/tasks/task_fiber.rb:15:in `block in create'
(celluloid):0:in `remote procedure call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:92:in `value'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/proxies/sync_proxy.rb:33:in `method_missing'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/resource.rb:132:in `raw_request'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/resource.rb:123:in `request'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/resources/cookbook_resource.rb:162:in `update'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/resources/cookbook_resource.rb:230:in `upload'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:26:in `public_send'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:26:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:63:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/cell.rb:60:in `block in invoke'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/cell.rb:71:in `block in task'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/actor.rb:357:in `block in task'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/tasks.rb:57:in `block in initialize'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/tasks/task_thread.rb:21:in `block in create'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/thread_handle.rb:13:in `block in initialize'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/actor_system.rb:32:in `block in get_thread'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/internal_pool.rb:130:in `call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/internal_pool.rb:130:in `block in create'
(celluloid):0:in `remote procedure call'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/calls.rb:92:in `value'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/celluloid-0.16.0/lib/celluloid/proxies/sync_proxy.rb:33:in `method_missing'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/uploader.rb:54:in `block (2 levels) in upload'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/uploader.rb:50:in `each'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/uploader.rb:50:in `block in upload'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley/client.rb:38:in `open'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/ridley-4.1.0/lib/ridley.rb:51:in `open'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf.rb:144:in `ridley_connection'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/uploader.rb:49:in `upload'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/uploader.rb:36:in `run'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/berksfile.rb:541:in `upload'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/cli.rb:208:in `upload'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/cli.rb:52:in `dispatch'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/lib/berkshelf/cli.rb:27:in `execute!'
/Users/pete/.rvm/gems/ruby-2.1.3/gems/berkshelf-3.2.1/bin/berks:5:in `<top (required)>'
/Users/pete/.rvm/gems/ruby-2.1.3/bin/berks:23:in `load'
/Users/pete/.rvm/gems/ruby-2.1.3/bin/berks:23:in `<main>'
/Users/pete/.rvm/gems/ruby-2.1.3/bin/ruby_executable_hooks:15:in `eval'
/Users/pete/.rvm/gems/ruby-2.1.3/bin/ruby_executable_hooks:15:in `<main>'

This can be resolved manually by finding the path to the cookbook

$ berks show elasticsearch

and deleting the .DS_Store files

find ~/.berkshelf/cookbooks/elasticsearch-0.3.12 -name '.DS_Store' -delete

I understand it would be preferable for this to be fixed in Berkshelf, but anything you folks can do here would be appreciated 😄

@karmi
Copy link
Contributor

karmi commented Jan 13, 2015

@peterjmit I probably have messed up the release, is this with the 0.3.12 version?

@peterjmit
Copy link
Author

@karmi I experienced this issue with 0.3.12, I have used 0.3.10 in the past so I know that is fine but I don't know about 0.3.11

@martinb3
Copy link
Contributor

Please try v0.3.13. It's been released to Supermarket and tags pushed to Github.

@peterjmit
Copy link
Author

Looks good, thanks @martinb3 @karmi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants