elasticsearch-cloud-aws plugin - fails to install, restarts service anyway

[wayne530]

this is problematic for a couple reasons:
(1) why do you install this plugin by default? not everyone uses aws. why not install 0 plugins by default and make users explicitly specify which plugins they want to use?
(2) the plugin fails to install but still has an action restart. this results in the ES process being restarted every time the chef-client runs, which is bad for obvious reasons:

[2013-09-10T17:41:42+00:00] INFO: Processing ruby_block[Install plugin: elasticsearch-cloud-aws] action create (elasticsearch::plugins line 35)
-> Installing elasticsearch-cloud-aws/1.12.0...
Trying https://github.com/elasticsearch-cloud-aws/1.12.0/zipball/master... (assuming site plugin)
Failed to install elasticsearch-cloud-aws/1.12.0, reason: failed to download out of all possible locations..., use -verbose to get detailed information
[2013-09-10T17:41:43+00:00] INFO: ruby_block[Install plugin: elasticsearch-cloud-aws] called
[2013-09-10T17:41:43+00:00] INFO: template[/etc/firewall/rules.iptables] sending run action to executerestore firewall
[2013-09-10T17:41:43+00:00] INFO: Processing execute[restore firewall] action run (afw::default line 48)
[2013-09-10T17:41:43+00:00] INFO: execute[restore firewall] ran successfully
[2013-09-10T17:41:43+00:00] INFO: ruby_block[Install plugin: elasticsearch-cloud-aws] sending restart action to serviceelasticsearch
[2013-09-10T17:41:43+00:00] INFO: Processing service[elasticsearch] action restart (elasticsearch::default line 63)
[2013-09-10T17:41:45+00:00] INFO: service[elasticsearch] restarted

[wayne530]

(2) is caused by the repo location getting moved without cleanup being added to remove the old attribute. manually removing the old elasticsearch-cloud-aws (note, not elasticsearch/elasticsearch-cloud-aws) plugins node will fix the issue. some cleanup is probably required as this breaks installs based on an older cookbook.

[karmi]

Could you explain (1) in more detail? The plugin is included only when you include the elasticsearch::aws plugin?

[karmi]

The plugin script now supports removing plugins, though I haven't thought about how to properly use it.

Can you explain (1) a little bit more? See my previous comment.