Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owning version of the Stream Iterator #4

Open
BonsaiDen opened this issue Apr 22, 2016 · 1 comment
Open

Owning version of the Stream Iterator #4

BonsaiDen opened this issue Apr 22, 2016 · 1 comment

Comments

@BonsaiDen
Copy link

Hey there,

first of all thanks for providing the library :)

Now, I'm currently using my own fork (not yet pushed to GH though) due to the needs to having a iterator which owns the stream it is using internally. (The containing struct is wrapped in a box and Send off to a thread which feeds the decoded audio over a voice connection).

It would be great if a "owning" version of the stream iterator could be added by default. In case you're too busy, I can probably find some free time over the course of this weekend and clean up my fork so it's suitable for a PR.

@sourrust
Copy link
Owner

sourrust commented Apr 25, 2016

Yes, pull requests are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants