Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate is_molecule_type for sourmash 4 #951

Closed
ctb opened this issue Apr 19, 2020 · 1 comment · Fixed by #1128
Closed

deprecate is_molecule_type for sourmash 4 #951

ctb opened this issue Apr 19, 2020 · 1 comment · Fixed by #1128
Labels
4.0 issues to address for a 4.0 release

Comments

@ctb
Copy link
Contributor

ctb commented Apr 19, 2020

per #936
@ctb ctb added the 4.0 issues to address for a 4.0 release label Apr 19, 2020
@ctb
Copy link
Contributor Author

ctb commented Jul 25, 2020

Trying it out in #1128 - easy to change, makes the code cleaner. 👍

@ctb ctb mentioned this issue Jul 31, 2020
Merged
19 tasks
@ctb ctb closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] MinHash class refactoring sourmash-bio/sourmash
1 participant
@ctb