Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Storage class to provide special methods for manifest loading and signature listing #1757

Open
ctb opened this issue Oct 19, 2021 · 1 comment

Comments

@ctb
Copy link
Contributor

ctb commented Oct 19, 2021

per #1598,

@ctb says:

in ZipFileLinearIndex, we have to break Storage encapsulation and go directly to the zipfile to get a list of all files, in cases where there is no manifest. (Listing all files is not an option supported through the current Storage interface.) There are two options for fixing this -

  1. provide a way to list all (relevant) files in a Storage. It's not clear to me that this is a good idea, because a Storage may contain many files and many signatures.
  2. require manifests when using zipfile collections. This seems fine to me, but would (I think) require a 5.0 release.

Ultimately I think we will probably want to implement both, but not today :)

See also discussion in #1441, and issue to require manifests in zipfiles #1755.

@ctb
Copy link
Contributor Author

ctb commented Oct 20, 2021

also see notebook in #1758, and comments therein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant