Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable saving of hashes w/abundances in multigather --output-unassigned #1464

Closed
ctb opened this issue Apr 16, 2021 · 6 comments
Closed

enable saving of hashes w/abundances in multigather --output-unassigned #1464

ctb opened this issue Apr 16, 2021 · 6 comments
Labels
good next issue An issue that should be ready to resolve. python Pull requests that update Python code

Comments

@ctb
Copy link
Contributor

ctb commented Apr 16, 2021

In #1392, I noticed that in src/sourmash/commands.py, function multigather, that abundances are not saved when unassigned hashes are output. See code block starting with with open(output_unassigned, 'wt') as fp:.

TODO:

  • look at the code in gather, and copy the code block to reinflate abundances over to multigather;
  • write tests for this feature of multigather (probably starting with the relevant test for gather, which is test_gather_output_unassigned_with_abundance)

This could wait until after #1463 is fixed, or be done in the same PR as that issue.

@ctb ctb added python Pull requests that update Python code good next issue An issue that should be ready to resolve. labels Apr 16, 2021
@keyabarve
Copy link
Contributor

@ctb I'd like to work on this issue.

@ctb
Copy link
Contributor Author

ctb commented Jun 14, 2021 via email

@keyabarve
Copy link
Contributor

@ctb Should #1463 be resolved before working on this?

@ctb
Copy link
Contributor Author

ctb commented Jun 16, 2021

This could wait until after #1463 is fixed, or be done in the same PR as that issue.

After, or during, either way.

@keyabarve
Copy link
Contributor

keyabarve commented Aug 14, 2021

@ctb Is this issue the same as #1707?

@ctb
Copy link
Contributor Author

ctb commented Aug 15, 2021

yep! closing as duplicate.

@ctb ctb closed this as completed Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good next issue An issue that should be ready to resolve. python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants