Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor LoadSingleSignatures? #1077

Closed
ctb opened this issue Jul 3, 2020 · 1 comment · Fixed by #1406
Closed

refactor LoadSingleSignatures? #1077

ctb opened this issue Jul 3, 2020 · 1 comment · Fixed by #1406

Comments

@ctb
Copy link
Contributor

ctb commented Jul 3, 2020

The sourmash_args.LoadSingleSignatures class used by categorize is kinda ugly. could be done along with #829.
@ctb
Copy link
Contributor Author

ctb commented Jul 3, 2020

in particular, it should use the _load_databases code underneath, if possible.

@ctb ctb mentioned this issue Mar 20, 2021
Merged
15 tasks
@ctb ctb mentioned this issue Mar 28, 2021
Merged
12 tasks
@ctb ctb closed this as completed in #1406 Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] refactor & clean up database loading around MultiIndex class sourmash-bio/sourmash
1 participant
@ctb