Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Bump ssh-agent action to v0.7.0 #978

Merged
merged 1 commit into from
Dec 23, 2022
Merged

ci: Bump ssh-agent action to v0.7.0 #978

merged 1 commit into from
Dec 23, 2022

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #977

Description

Bumps the ssh-agent github action to version v0.7.0 and uses some new configuration option(s).

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI

Specify the platform(s) on which this was tested:

  • Manjaro

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. action/no-benchmark Skips the action that runs the benchmark. labels Dec 17, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.4 milestone Dec 17, 2022
@shahzadlone shahzadlone requested a review from a team December 17, 2022 21:19
@shahzadlone shahzadlone self-assigned this Dec 17, 2022
@shahzadlone shahzadlone changed the title PR: Bump - Update ssh-agent and don't log the key. ci: Bump ssh-agent action to v0.7.0 Dec 17, 2022
@shahzadlone shahzadlone force-pushed the lone/chore/bump-webfactory-ssh-agent branch from 48c7775 to 7fe74ce Compare December 17, 2022 23:08
AndrewSisley
AndrewSisley approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what promted this now though?

@shahzadlone
Copy link
Member Author

LGTM, what promted this now though?

Because I didn't want to wait until our actions stop failing and there were some Warnings propping up.

@AndrewSisley
Copy link
Contributor

LGTM, what promted this now though?

Because I didn't want to wait until our actions stop failing and there were some Warnings propping up.

Github actions only support a range of versions?

@shahzadlone
Copy link
Member Author

LGTM, what promted this now though?

Because I didn't want to wait until our actions stop failing and there were some Warnings propping up.

Github actions only support a range of versions?

Github actions is deprecating all actions (old versions) that depend on Node 12 as it has been out of support since April 2022

@shahzadlone shahzadlone force-pushed the lone/chore/bump-webfactory-ssh-agent branch from 7fe74ce to 16a38ae Compare December 23, 2022 17:04
@shahzadlone shahzadlone merged commit c1d160f into develop Dec 23, 2022
@shahzadlone shahzadlone deleted the lone/chore/bump-webfactory-ssh-agent branch December 23, 2022 17:21
@shahzadlone shahzadlone mentioned this pull request Dec 23, 2022
Merged
4 tasks
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Bump ssh-agent action to v0.7.0 (sourcenetwork#978)
41f6255 
- Resolves sourcenetwork#977 

- Bumps the `ssh-agent` github action to version [v0.7.0](https://github.com/webfactory/ssh-agent/tree/v0.7.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump ssh-agent action to v0.7.0
2 participants
@shahzadlone @AndrewSisley