chore: Extract inline (http and client) errors to errors.go #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/errors
Codecov Report
@@ Coverage Diff @@
## develop #967 +/- ##
===========================================
- Coverage 59.95% 59.86% -0.10%
===========================================
Files 157 157
Lines 17687 17716 +29
===========================================
+ Hits 10604 10605 +1
- Misses 6129 6157 +28
Partials 954 954
|
AndrewSisley
changed the title
AndrewSisley
changed the title
AndrewSisley
changed the title
AndrewSisley
changed the title
|
Splitting it up in multiple PRs is a good idea 👍 |
fredcarle
approved these changes
Dec 14, 2022
api/http/errors.go
Outdated
| ErrNoListener = errors.New("cannot serve with no listener") | ||
| ErrSchema = errors.New("base must start with the http or https scheme") | ||
| ErrDatabaseNotAvailable = errors.New("no database available") | ||
| ErrXFormNotSupported = errors.New("content type application/x-www-form-urlencoded not yet supported") |
There was a problem hiding this comment.
nitpick: The X can be removed in the name.
There was a problem hiding this comment.
thanks -wasnt sure what I could chop here
- drop X
| @@ -21,9 +21,19 @@ import ( | |||
|
|
|||
| var env = os.Getenv("DEFRA_ENV") | |||
|
|
|||
| // Errors returnable from this package. | |||
There was a problem hiding this comment.
suggestion: Putting this here because I can't comment directly on the import. I think it would be a good idea to use Defra's errors package instead of the stdlib one so that we can benefit from stacktraces.
There was a problem hiding this comment.
! good spot, I didnt notice - should definately be using our errors. Thanks
- use our errors
I realized that continuing this in this package would be ineffiecient as Orpheus is reworking it at the moment. He said (without seeing these changes) that it was still useful and shouldnt clash too hard, but I think it would be better to wait a bit to do the rest of the package.
AndrewSisley
force-pushed
the
sisley/chore/I257-errors-go
branch
from
0ebc396 to
f6bc237
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…twork#967) * Move unexpected type error to client * Make existing http errors public * Extract http errors to errors.go * Extract some cli errors * Extract client errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Part of #257
Description
Extracts inline errors to package errors.go for the http and client packages, and a couple of the ones in cli (see commit message for more info there).
My gut is staying to chunk this up into multiple PRs, but I dont want to spam you guys on a per-package basis. Will likely be doing this in 2-3 package chunks - do let me know your thoughts on this, the commits will be per package anyway, and the PRs will likely be based of one another so it doesnt really affect me personally too much one way or the other (minus any conflicts from larger merge-latency with larger PRs).