Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent errors.go design across codebase #937

Closed
jsimnz opened this issue Nov 12, 2022 · 1 comment
Closed

Consistent errors.go design across codebase #937

jsimnz opened this issue Nov 12, 2022 · 1 comment
Labels
area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.5

Comments

@jsimnz
Copy link
Member

jsimnz commented Nov 12, 2022

context: https://github.com/sourcenetwork/defradb/pull/931/files#r1014251446

At the moment, package level errors are sprinkled all over as inline definitions.

We have discussed a consistent design for (all) packages to have a defined errors.go that includes typed error definitions.
@jsimnz jsimnz added area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components labels Nov 12, 2022
@jsimnz jsimnz mentioned this issue Nov 12, 2022
Merged
3 tasks
@jsimnz jsimnz added this to the DefraDB v0.5 milestone Nov 15, 2022
@jsimnz
Copy link
Member Author

jsimnz commented Mar 23, 2023

duplicate of #257

@jsimnz jsimnz closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.5
Development

No branches or pull requests
1 participant
@jsimnz