-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Include version metadata in cross-building #930
Merged
orpheuslummis
merged 1 commit into
develop
from
orpheus/chore/version-metadata-crossbuild
Nov 4, 2022
Merged
chore: Include version metadata in cross-building #930
orpheuslummis
merged 1 commit into
develop
from
orpheus/chore/version-metadata-crossbuild
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #930 +/- ##
===========================================
- Coverage 60.05% 60.05% -0.01%
===========================================
Files 159 159
Lines 17532 17532
===========================================
- Hits 10529 10528 -1
- Misses 6066 6067 +1
Partials 937 937
|
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
jsimnz
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Smart move re-using the make build
command in the cross-build file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #929
Description
Leverage Makefile in cross-building script for that is what adds metadata to build process.
Tasks
How has this been tested?
Tested only one binary, by cross-building on arm64 MacOS, and running a resulting binary on amd64 Linux.