Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits: Add collection id field to commits fields #849

Closed
AndrewSisley opened this issue Sep 22, 2022 · 3 comments · Fixed by #1235
Closed

Commits: Add collection id field to commits fields #849

AndrewSisley opened this issue Sep 22, 2022 · 3 comments · Fixed by #1235
Assignees
Labels
area/query Related to the query component feature New feature or request
Milestone

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Sep 22, 2022

Part of #549

We want a new field that holds the id of the collection that the commit was commited against. It should be requestable via the commits and latestCommits queries. Grouping by this field should probably be tested in this ticket as we may gain that (desired) behaviour for free.

@AndrewSisley AndrewSisley added feature New feature or request area/query Related to the query component labels Sep 22, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Sep 22, 2022
@AndrewSisley AndrewSisley self-assigned this Oct 24, 2022
@AndrewSisley
Copy link
Contributor Author

AndrewSisley commented Oct 27, 2022

Had a good old chat about this on Discord, thread dev-db/"Commit index(es)" https://discord.com/channels/427944769851752448/1034921488618360883

Will park this issue until after the implementation of branchable collections, as significant changes may be made then.

Is some WIP code in sisley/feat/I849-commit-collection-id-2, but how much of it will be useful by the time this gets picked up again is unknown

@AndrewSisley AndrewSisley modified the milestones: DefraDB v0.4, DefraDB v0.5 Oct 27, 2022
@AndrewSisley AndrewSisley removed their assignment Oct 27, 2022
@islamaliev
Copy link
Contributor

@AndrewSisley does it mean the task in not ready yet? Maybe then it makes sense to move it to "Blocked" column?

@AndrewSisley
Copy link
Contributor Author

I'd prefer not to keep backlog items in 'blocked', it would grow to be pointlessly busy.

This ticket might actually be quite easy now, as the Schema Version ID has been added to commits since and can probably be used to get the collection ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants