Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve UX by providing more information #802

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Sep 15, 2022

Relevant issue(s)

Resolves #801

Description

Details

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Specify the platform(s) on which this was tested:

  • MacOS

@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label Sep 15, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3.1 milestone Sep 15, 2022
@orpheuslummis orpheuslummis self-assigned this Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #802 (873f45d) into develop (af0022f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #802   +/-   ##
========================================
  Coverage    59.60%   59.61%           
========================================
  Files          154      154           
  Lines        17256    17257    +1     
========================================
+ Hits         10286    10287    +1     
  Misses        6044     6044           
  Partials       926      926           
Impacted Files Coverage Δ
db/collection.go 65.92% <ø> (ø)
api/http/handlerfuncs.go 89.07% <100.00%> (+0.06%) ⬆️
api/http/logger.go 100.00% <100.00%> (ø)

@orpheuslummis
Copy link
Contributor Author

feel free to suggest more and we can bundle them here

@orpheuslummis orpheuslummis changed the title chore: Small tweaks improving experience chore: Improve user experience by providing a bit more information Sep 15, 2022
@orpheuslummis orpheuslummis changed the title chore: Improve user experience by providing a bit more information chore: Improve UX by providing more information Sep 15, 2022
@orpheuslummis orpheuslummis force-pushed the orpheus/chore/experiencial-tweaks branch from 46dc883 to cfccace Compare September 16, 2022 11:32
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orpheuslummis orpheuslummis force-pushed the orpheus/chore/experiencial-tweaks branch from cfccace to 873f45d Compare September 16, 2022 17:36
@orpheuslummis orpheuslummis merged commit 2882088 into develop Sep 16, 2022
@orpheuslummis orpheuslummis deleted the orpheus/chore/experiencial-tweaks branch September 16, 2022 17:52
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small experiencial tweaks 0.3.1
3 participants