fix: Error if child _group selected without parent groupBy #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
changed the title
fredcarle
approved these changes
Sep 8, 2022
AndrewSisley
force-pushed
the
sisley/fix/I702-count-on-non-group
branch
from
edf6b34 to
80ebca4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #781 +/- ##
===========================================
+ Coverage 58.72% 58.79% +0.07%
===========================================
Files 153 153
Lines 17120 17123 +3
===========================================
+ Hits 10053 10068 +15
+ Misses 6129 6121 -8
+ Partials 938 934 -4
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…work#781) * Handle non-existant group selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #702
Description
Error pleasantly if child _group selected without parent groupBy. Proposed fix is the simple solution, however there was talk about adding a query validation package/stage (possibly between mapper and planner), however that would take a fair amount more effort, and currently this might be the only item requiring it - if there are others I would suggest noting them all in a refactor ticket and moving them (including this simple fix) to that system in a dedicated ticket - but let me know as we did mention this in standup I think.
Specify the platform(s) on which this was tested: