Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to v0.20.3 of libp2p #740

Merged
merged 4 commits into from
Aug 16, 2022
Merged

chore: Update to v0.20.3 of libp2p #740

merged 4 commits into from
Aug 16, 2022

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #592

Description

This PR updates the libp2p package to version 0.20.3.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Unit tests

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added area/p2p Related to the p2p networking system action/no-benchmark Skips the action that runs the benchmark. labels Aug 15, 2022
@fredcarle fredcarle added this to the DefraDB v0.3.1 milestone Aug 15, 2022
@fredcarle fredcarle requested a review from a team August 15, 2022 17:57
@fredcarle fredcarle self-assigned this Aug 15, 2022
jsimnz
jsimnz approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shahzadlone
shahzadlone approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but the validation action might fail when you rebase as the last character of the PR title is not a lowercase alphabet. Perhaps we should allow the last character to be a number.

@fredcarle fredcarle force-pushed the fredcarle/chore/I592-libp2p-update branch from 928b391 to 4d59fb9 Compare August 16, 2022 03:44
@fredcarle fredcarle changed the title chore: Update libp2p to v0.20.3 chore: Update to v0.20.3 of libp2p Aug 16, 2022
@fredcarle fredcarle merged commit 413f32c into develop Aug 16, 2022
@fredcarle fredcarle deleted the fredcarle/chore/I592-libp2p-update branch August 16, 2022 03:55
@orpheuslummis
Copy link
Contributor

What was different this time?

@fredcarle
Copy link
Collaborator Author

What was different this time?

Not 100% sure. I went one dependency at a time and I think it made it easier to align the versions.

shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@fredcarle
chore: Update to v0.20.3 of libp2p (sourcenetwork#740)
c53dcb4 
Description
This PR updates the libp2p package to version 0.20.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz approved these changes

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@fredcarle fredcarle

Labels
action/no-benchmark Skips the action that runs the benchmark. area/p2p Related to the p2p networking system
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging this pull request may close these issues.

Update dependency libp2p to v0.20
4 participants
@fredcarle @orpheuslummis @jsimnz @shahzadlone