refactor: Change logging calls to use feedback in CLI package #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
refactor
fredcarle
force-pushed
the
fredcarle/refactor/I662-logger-to-feedback
branch
from
935d515 to
747e8f9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #714 +/- ##
========================================
Coverage 57.42% 57.43%
========================================
Files 143 143
Lines 16408 16406 -2
========================================
Hits 9422 9422
+ Misses 6102 6100 -2
Partials 884 884
|
shahzadlone
reviewed
Aug 3, 2022
| n.Close() //nolint:errcheck | ||
| db.Close(cmd.Context()) | ||
| return err | ||
| return fmt.Errorf("failed to start P2P node: %w", err) |
There was a problem hiding this comment.
question: We remove logging here because we will log it once it bubble ups?
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…network#714) Relevant issue(s) Resolves sourcenetwork#662 Description This PR changes all logging calls in the CLI package to include feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #662
Description
This PR changes all logging calls in the CLI package to include feedback.
Tasks
How has this been tested?
manual check
Specify the platform(s) on which this was tested: