-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Utility for generation of man pages #493
Conversation
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
I suggest that integrating man page generation in packaging for specific systems to be implemented in future PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice little utility :)
I would like to suggest moving this to /cmd/genman
. The Go convention is to put command line tools/utils/apps under the cmd
package. See https://github.com/kubernetes/kubernetes as an example.
thought: Currently we ignore |
Merci @fredcarle |
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
This is now waiting for #501 |
6d08ce1
to
ad34fbe
Compare
This PR is as follows now:
The reasoning:
Of course this is subject to change if there's a better path suggested.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Good job.
Not sure I should / can approve defra stuff but LGTM
In my opinion: It's reasonable for you to approve this as it's not deeply DefraDB-related and you probably have PR-related domain knowledge. Contribution boundaries for core devs are more guided by reason than by bureaucratical walls. That said, even though it is not an important change, I recommend to myself to only merge when most relevant stakeholders have approved, so in this case when a db-core team member will have approved and after some time has passed for possible criticism from the team to surface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤘
LGTM. |
RELEVANT ISSUE(S)
Resolves #258
DESCRIPTION
Small utility to generate man pages of the CLI.
HOW HAS THIS BEEN TESTED?
Manual testing.
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):