Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linter for Proper Error Handling #42

Closed
Tracked by #37
shahzadlone opened this issue Nov 16, 2021 · 1 comment · Fixed by #63
Closed
Tracked by #37

Add Linter for Proper Error Handling #42

shahzadlone opened this issue Nov 16, 2021 · 1 comment · Fixed by #63
Assignees
@shahzadlone
Labels
area/errors Related to the internal management or design of our error handling system
Milestone
DefraDB v0.2

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Nov 16, 2021 •
edited
Loading

This is being made into it's own task.

Essentially to be completed and merged after this PR is merged(#41) and this Issue is resolved (#36).

Add Linter for Error Handling, In order to make error handling consistent and help us mortals catch bad error handling pracitices.

Use this:
https://github.com/polyfloyd/go-errorlint
@shahzadlone shahzadlone self-assigned this Nov 16, 2021
@shahzadlone shahzadlone mentioned this issue Nov 16, 2021
Closed
@shahzadlone shahzadlone added this to the DefraDB v0.2 milestone Nov 16, 2021
@jsimnz jsimnz mentioned this issue Nov 23, 2021
Closed
1 task
@shahzadlone shahzadlone mentioned this issue Nov 30, 2021
Merged
@jsimnz jsimnz linked a pull request Dec 2, 2021 that will close this issue
refactor: Cleanup Linter Complaints and Setup Makefile #63
Merged
@jsimnz jsimnz added the area/errors Related to the internal management or design of our error handling system label Dec 2, 2021
@shahzadlone
Copy link
Member Author

More like merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
area/errors Related to the internal management or design of our error handling system
Projects
None yet
Milestone
DefraDB v0.2
Development

Successfully merging a pull request may close this issue.

refactor: Cleanup Linter Complaints and Setup Makefile sourcenetwork/defradb
2 participants
@jsimnz @shahzadlone