Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Cleanup linter config file #400

Merged
merged 3 commits into from
May 5, 2022
Merged

tools: Cleanup linter config file #400

merged 3 commits into from
May 5, 2022

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented May 5, 2022 •
edited
Loading

RELATED ISSUE(S):

Resolves #399

DESCRIPTION:

Removed all unused linters from the golangci.yaml config file to keep it in a clean state. From now on only add configs for the linters we do need.

@shahzadlone shahzadlone added the code quality Related to improving code quality label May 5, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone May 5, 2022
@shahzadlone shahzadlone self-assigned this May 5, 2022
@shahzadlone shahzadlone changed the title tools: Clean the golangci.yaml linter config file. tools: Clean linter config file. May 5, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 108 Benchmarks were ✅ Better.
  • 5 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4265ms ± 0%218ms ± 0%−17.79%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.6ms ± 0%10.4ms ± 0%−17.30%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4126ms ± 0%97ms ± 0%−22.78%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.15s ± 0%0.98s ± 0%−15.05%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-449.2ms ± 0%44.4ms ± 0%−9.76%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4475ms ± 0%433ms ± 0%−9.01%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.84s ± 0%4.50s ± 0%−6.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4394µs ± 0%325µs ± 0%−17.54%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.54ms ± 0%3.58ms ± 0%−21.06%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.9ms ± 0%39.1ms ± 0%−4.41%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4390µs ± 0%355µs ± 0%−8.86%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.03ms ± 0%3.80ms ± 0%−5.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4289µs ± 0%252µs ± 0%−13.04%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.85ms ± 0%1.71ms ± 0%−7.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.4ms ± 0%23.2ms ± 0%−5.27%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4259µs ± 0%254µs ± 0%−2.01%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.91ms ± 0%1.85ms ± 0%−3.42%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.25ms ± 0%1.16ms ± 0%−7.37%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.75ms ± 0%9.19ms ± 0%−5.78%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4482µs ± 0%414µs ± 0%−14.18%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.31ms ± 0%1.21ms ± 0%−7.59%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%9.8ms ± 0%−3.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4470µs ± 0%369µs ± 0%−21.35%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4531µs ± 0%433µs ± 0%−18.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4478µs ± 0%421µs ± 0%−11.93%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4710µs ± 0%638µs ± 0%−10.08%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4711µs ± 0%627µs ± 0%−11.86%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4656µs ± 0%634µs ± 0%−3.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4321µs ± 0%274µs ± 0%−14.65%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4342µs ± 0%270µs ± 0%−21.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4277µs ± 0%271µs ± 0%−2.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4484µs ± 0%414µs ± 0%−14.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.47ms ± 0%1.32ms ± 0%−9.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.3ms ± 0%12.2ms ± 0%−1.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.9µs ± 0%12.7µs ± 0%−14.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.0µs ± 0%13.7µs ± 0%−2.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.6µs ± 0%15.2µs ± 0%−13.97%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.2µs ± 0%19.0µs ± 0%−5.90%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4148µs ± 0%132µs ± 0%−11.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4136µs ± 0%127µs ± 0%−6.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4148µs ± 0%145µs ± 0%−2.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4182µs ± 0%158µs ± 0%−12.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4211µs ± 0%192µs ± 0%−8.95%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.1µs ± 0%14.3µs ± 0%−16.14%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%15.1µs ± 0%−12.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%15.5µs ± 0%−1.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-419.0µs ± 0%17.0µs ± 0%−10.63%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-424.0µs ± 0%20.3µs ± 0%−15.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4161µs ± 0%129µs ± 0%−19.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4170µs ± 0%138µs ± 0%−18.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4186µs ± 0%147µs ± 0%−20.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4220µs ± 0%159µs ± 0%−27.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4248µs ± 0%198µs ± 0%−20.29%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-448.3µs ± 0%45.6µs ± 0%−5.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-454.9µs ± 0%46.8µs ± 0%−14.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-456.8µs ± 0%48.6µs ± 0%−14.45%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-463.9µs ± 0%54.1µs ± 0%−15.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-476.9µs ± 0%67.1µs ± 0%−12.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4364µs ± 0%354µs ± 0%−2.60%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4392µs ± 0%366µs ± 0%−6.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4389µs ± 0%354µs ± 0%−9.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4428µs ± 0%394µs ± 0%−7.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4526µs ± 0%491µs ± 0%−6.56%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-449.4µs ± 0%45.4µs ± 0%−8.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-449.4µs ± 0%47.3µs ± 0%−4.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.2µs ± 0%52.6µs ± 0%−6.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.0µs ± 0%67.1µs ± 0%−5.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4354µs ± 0%350µs ± 0%−0.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4383µs ± 0%352µs ± 0%−8.05%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4422µs ± 0%364µs ± 0%−13.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4450µs ± 0%408µs ± 0%−9.31%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4579µs ± 0%493µs ± 0%−14.84%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4123µs ± 0%121µs ± 0%−1.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4127µs ± 0%124µs ± 0%−2.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4138µs ± 0%124µs ± 0%−10.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4168µs ± 0%139µs ± 0%−17.33%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.35ms ± 0%1.17ms ± 0%−12.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.45ms ± 0%1.18ms ± 0%−18.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.41ms ± 0%1.20ms ± 0%−14.82%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.32ms ± 0%1.25ms ± 0%−5.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.41ms ± 0%1.36ms ± 0%−3.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%113µs ± 0%−4.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4117µs ± 0%117µs ± 0%−0.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4128µs ± 0%114µs ± 0%−10.98%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%122µs ± 0%−2.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%132µs ± 0%−3.20%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.30ms ± 0%1.15ms ± 0%−11.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.22ms ± 0%1.16ms ± 0%−4.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.15ms ± 0%−4.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.28ms ± 0%1.19ms ± 0%−6.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.45ms ± 0%1.32ms ± 0%−9.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.68µs ± 0%8.64µs ± 0%−0.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.1µs ± 0%10.0µs ± 0%−1.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.8µs ± 0%14.0µs ± 0%−11.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-494.6µs ± 0%87.2µs ± 0%−7.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-498.8µs ± 0%95.4µs ± 0%−3.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4105µs ± 0%104µs ± 0%−0.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4126µs ± 0%115µs ± 0%−8.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4165µs ± 0%149µs ± 0%−9.58%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4129µs ± 0%127µs ± 0%−0.85%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4129µs ± 0%120µs ± 0%−7.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4130µs ± 0%122µs ± 0%−6.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4132µs ± 0%130µs ± 0%−1.95%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%127µs ± 0%−8.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.23ms ± 0%1.23ms ± 0%−0.02%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.25ms ± 0%1.25ms ± 0%−0.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.44ms ± 0%1.22ms ± 0%−15.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.40ms ± 0%1.22ms ± 0%−12.51%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-444.4µs ± 0%45.0µs ± 0%+1.48%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4117µs ± 0%118µs ± 0%+0.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.66µs ± 0%8.96µs ± 0%+3.42%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.5µs ± 0%12.7µs ± 0%+1.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.35ms ± 0%1.35ms ± 0%+0.34%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.2ms ± 0%10.7ms ± 0%−4.63%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4265ms ± 0%218ms ± 0%−17.79%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.6ms ± 0%10.4ms ± 0%−17.30%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4126ms ± 0%97ms ± 0%−22.78%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.15s ± 0%0.98s ± 0%−15.05%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-449.2ms ± 0%44.4ms ± 0%−9.76%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4475ms ± 0%433ms ± 0%−9.01%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.84s ± 0%4.50s ± 0%−6.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4394µs ± 0%325µs ± 0%−17.54%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.54ms ± 0%3.58ms ± 0%−21.06%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.9ms ± 0%39.1ms ± 0%−4.41%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4390µs ± 0%355µs ± 0%−8.86%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.03ms ± 0%3.80ms ± 0%−5.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4289µs ± 0%252µs ± 0%−13.04%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.85ms ± 0%1.71ms ± 0%−7.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.4ms ± 0%23.2ms ± 0%−5.27%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4259µs ± 0%254µs ± 0%−2.01%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.91ms ± 0%1.85ms ± 0%−3.42%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4370µs ± 0%339µs ± 0%−8.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.25ms ± 0%1.16ms ± 0%−7.37%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.75ms ± 0%9.19ms ± 0%−5.78%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4482µs ± 0%414µs ± 0%−14.18%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.31ms ± 0%1.21ms ± 0%−7.59%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%9.8ms ± 0%−3.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4470µs ± 0%369µs ± 0%−21.35%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4531µs ± 0%433µs ± 0%−18.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4478µs ± 0%421µs ± 0%−11.93%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4710µs ± 0%638µs ± 0%−10.08%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4711µs ± 0%627µs ± 0%−11.86%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4656µs ± 0%634µs ± 0%−3.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4321µs ± 0%274µs ± 0%−14.65%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4342µs ± 0%270µs ± 0%−21.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4277µs ± 0%271µs ± 0%−2.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4484µs ± 0%414µs ± 0%−14.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.47ms ± 0%1.32ms ± 0%−9.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.3ms ± 0%12.2ms ± 0%−1.47%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-414.1µs ± 0%13.1µs ± 0%−6.97%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.9µs ± 0%12.7µs ± 0%−14.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.0µs ± 0%13.7µs ± 0%−2.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.6µs ± 0%15.2µs ± 0%−13.97%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.2µs ± 0%19.0µs ± 0%−5.90%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4148µs ± 0%132µs ± 0%−11.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4136µs ± 0%127µs ± 0%−6.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4148µs ± 0%145µs ± 0%−2.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4182µs ± 0%158µs ± 0%−12.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4211µs ± 0%192µs ± 0%−8.95%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.1µs ± 0%14.3µs ± 0%−16.14%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%15.1µs ± 0%−12.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%15.5µs ± 0%−1.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-419.0µs ± 0%17.0µs ± 0%−10.63%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-424.0µs ± 0%20.3µs ± 0%−15.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4161µs ± 0%129µs ± 0%−19.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4170µs ± 0%138µs ± 0%−18.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4186µs ± 0%147µs ± 0%−20.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4220µs ± 0%159µs ± 0%−27.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4248µs ± 0%198µs ± 0%−20.29%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-448.3µs ± 0%45.6µs ± 0%−5.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-454.9µs ± 0%46.8µs ± 0%−14.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-456.8µs ± 0%48.6µs ± 0%−14.45%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-463.9µs ± 0%54.1µs ± 0%−15.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-476.9µs ± 0%67.1µs ± 0%−12.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4364µs ± 0%354µs ± 0%−2.60%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4392µs ± 0%366µs ± 0%−6.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4389µs ± 0%354µs ± 0%−9.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4428µs ± 0%394µs ± 0%−7.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4526µs ± 0%491µs ± 0%−6.56%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-444.4µs ± 0%45.0µs ± 0%+1.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-449.4µs ± 0%45.4µs ± 0%−8.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-449.4µs ± 0%47.3µs ± 0%−4.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.2µs ± 0%52.6µs ± 0%−6.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.0µs ± 0%67.1µs ± 0%−5.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4354µs ± 0%350µs ± 0%−0.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4383µs ± 0%352µs ± 0%−8.05%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4422µs ± 0%364µs ± 0%−13.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4450µs ± 0%408µs ± 0%−9.31%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4579µs ± 0%493µs ± 0%−14.84%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4117µs ± 0%118µs ± 0%+0.62%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4123µs ± 0%121µs ± 0%−1.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4127µs ± 0%124µs ± 0%−2.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4138µs ± 0%124µs ± 0%−10.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4168µs ± 0%139µs ± 0%−17.33%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.35ms ± 0%1.17ms ± 0%−12.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.45ms ± 0%1.18ms ± 0%−18.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.41ms ± 0%1.20ms ± 0%−14.82%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.32ms ± 0%1.25ms ± 0%−5.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.41ms ± 0%1.36ms ± 0%−3.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%113µs ± 0%−4.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4117µs ± 0%117µs ± 0%−0.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4128µs ± 0%114µs ± 0%−10.98%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%122µs ± 0%−2.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%132µs ± 0%−3.20%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.30ms ± 0%1.15ms ± 0%−11.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.22ms ± 0%1.16ms ± 0%−4.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.15ms ± 0%−4.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.28ms ± 0%1.19ms ± 0%−6.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.45ms ± 0%1.32ms ± 0%−9.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.66µs ± 0%8.96µs ± 0%+3.42%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.68µs ± 0%8.64µs ± 0%−0.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.1µs ± 0%10.0µs ± 0%−1.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.5µs ± 0%12.7µs ± 0%+1.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.8µs ± 0%14.0µs ± 0%−11.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-494.6µs ± 0%87.2µs ± 0%−7.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-498.8µs ± 0%95.4µs ± 0%−3.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4105µs ± 0%104µs ± 0%−0.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4126µs ± 0%115µs ± 0%−8.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4165µs ± 0%149µs ± 0%−9.58%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4129µs ± 0%127µs ± 0%−0.85%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4129µs ± 0%120µs ± 0%−7.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4130µs ± 0%122µs ± 0%−6.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4132µs ± 0%130µs ± 0%−1.95%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%127µs ± 0%−8.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.23ms ± 0%1.23ms ± 0%−0.02%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.25ms ± 0%1.25ms ± 0%−0.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.44ms ± 0%1.22ms ± 0%−15.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.40ms ± 0%1.22ms ± 0%−12.51%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.35ms ± 0%1.35ms ± 0%+0.34%(p=1.000 n=1+1)
 

orpheuslummis
orpheuslummis approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndrewSisley
AndrewSisley requested changes May 5, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for the cleanup, I have one request, but dont wait for my approval before merging if you make the change

tools/configs/golangci.yaml Show resolved Hide resolved
@shahzadlone shahzadlone requested a review from AndrewSisley May 5, 2022 23:01
@shahzadlone shahzadlone changed the title tools: Clean linter config file. tools: Cleanup linter config file May 5, 2022
@shahzadlone shahzadlone merged commit 40bca34 into develop May 5, 2022
@shahzadlone shahzadlone deleted the lone/tools/clean-linter-config-file branch May 5, 2022 23:07
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
tools: Cleanup linter config file (sourcenetwork#400)
57f1e88 
- RELATED ISSUE(S):
Resolves sourcenetwork#399

- DESCRIPTION:
Removed all unused linters from the `golangci.yaml` config file to keep it in a clean state. From now on only add configs for the linters we do need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@fredcarle fredcarle Awaiting requested review from fredcarle

@jsimnz jsimnz Awaiting requested review from jsimnz

@AndrewSisley AndrewSisley Awaiting requested review from AndrewSisley

Assignees

@shahzadlone shahzadlone

Labels
code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Lint: Clean up the .golangci.yaml config file
4 participants
@shahzadlone @source-devs @orpheuslummis @AndrewSisley