Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Store.GetCollections functions #2289

Closed
AndrewSisley opened this issue Feb 7, 2024 · 1 comment
Closed

Unify Store.GetCollections functions #2289

AndrewSisley opened this issue Feb 7, 2024 · 1 comment
Labels
area/collections Related to the collections system feature New feature or request

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Feb 7, 2024 •
edited
Loading

Currently we have 4 funcs that do roughly the same thing but with slight variations:

  • GetCollectionByName
  • GetCollectionsBySchemaRoot
  • GetCollectionsByVersionID
  • GetAllCollections

The CLI and Http clients do not follow this pattern, and have a single collections access point.

#2286 worsens this issue by introducing a bool that allows the retrieval of inactive collections.

We should change the Go client to match the CLI and Http clients (single func).

See also #2290 and #2146
@AndrewSisley AndrewSisley added feature New feature or request area/collections Related to the collections system labels Feb 7, 2024
This was referenced Feb 7, 2024
Merged
Closed
@AndrewSisley
Copy link
Contributor Author

Duplicate of #2008

@AndrewSisley AndrewSisley marked this as a duplicate of #2008 Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/collections Related to the collections system feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewSisley