fix: Fix test module relying on closed memory leak #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only half fixes this, it will be solved properly in lens-vm/lens#62
AndrewSisley
added
area/schema
AndrewSisley
changed the title
fredcarle
approved these changes
Nov 10, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## develop #2037 +/- ##
===========================================
- Coverage 73.87% 73.86% -0.01%
===========================================
Files 248 248
Lines 24801 24801
===========================================
- Hits 18321 18318 -3
- Misses 5220 5222 +2
- Partials 1260 1261 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#2036 ## Description Fix module relying on closed memory leak. It only half fixes this, it will be solved properly in lens-vm/lens#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2036
Description
Fix module relying on closed memory leak.
It only half fixes this, it will be solved properly in lens-vm/lens#62