fix: Remove test reference to DEFRA_ROOTDIR env var #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
documentation
AndrewSisley
force-pushed
the
sisley/fix/I1327-DEFRA_ROOTDIR
branch
from
ba7411b to
8613d86
Compare
|
Config file commit dropped, as it is already being removed in #1318 Will just drop the test here |
AndrewSisley
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1328 +/- ##
===========================================
+ Coverage 70.60% 70.63% +0.03%
===========================================
Files 184 184
Lines 17784 17784
===========================================
+ Hits 12556 12562 +6
+ Misses 4274 4270 -4
+ Partials 954 952 -2 |
AndrewSisley
force-pushed
the
sisley/fix/I1327-DEFRA_ROOTDIR
branch
from
38e4a6b to
8613d86
Compare
Test does not add any value IMO, and can almost suggest that this env var exists and is meaningful
AndrewSisley
force-pushed
the
sisley/fix/I1327-DEFRA_ROOTDIR
branch
from
8613d86 to
96e73fc
Compare
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1327
Description
This environment variable does not exist, so I think we should remove all references to it.