fix: Fix panic on success of Add/RemoveP2PCollections #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto generated code expects a non nil result if error is nil, and will panic otherwise.
The auto generated code expects a non nil result if error is nil, and will panic otherwise.
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1297 +/- ##
===========================================
- Coverage 70.51% 70.45% -0.06%
===========================================
Files 184 184
Lines 17817 17825 +8
===========================================
- Hits 12563 12558 -5
- Misses 4300 4314 +14
+ Partials 954 953 -1
|
fredcarle
approved these changes
Apr 5, 2023
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Return empty value on AddP2PCollections success The auto generated code expects a non nil result if error is nil, and will panic otherwise. * Return empty value on RemoveP2PCollections success The auto generated code expects a non nil result if error is nil, and will panic otherwise.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…1297) * Return empty value on AddP2PCollections success The auto generated code expects a non nil result if error is nil, and will panic otherwise. * Return empty value on RemoveP2PCollections success The auto generated code expects a non nil result if error is nil, and will panic otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1296
Description
Fixes a panic on success of Add/RemoveP2PCollections. The auto generated code expects a non nil result if error is nil, and will panic otherwise.