Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise storing children links by MerkleClock #1217

Closed
islamaliev opened this issue Mar 22, 2023 · 2 comments
Closed

Optimise storing children links by MerkleClock #1217

islamaliev opened this issue Mar 22, 2023 · 2 comments
Labels
perf Performance issue or suggestion

Comments

@islamaliev
Copy link
Contributor

When storing children links in the merkle/clock/clock.go:ProcessNode method mc.headset.Write(ctx, root, rootPrio) is called in the loop for every child although it stores the same value (not child related)

@islamaliev islamaliev added the perf Performance issue or suggestion label Mar 22, 2023
@jsimnz
Copy link
Member

jsimnz commented Mar 22, 2023

This will likely be related to #1066. Since we merge in the reverse direction, the headset Write is basically doing useless work as you note here.

Once 1066 is fixed, this will change, as it will make the "merge direction" for the CRDT forwards instead of backwards. Which will mean that each headset update will actually be a new update

@fredcarle
Copy link
Collaborator

closed by #2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance issue or suggestion
Projects
None yet
Development

No branches or pull requests

3 participants