Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Extract query parser errors to dedicated file #1035

Merged
merged 1 commit into from
Jan 16, 2023
Merged

refactor: Extract query parser errors to dedicated file #1035

merged 1 commit into from
Jan 16, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Part of #257

Description

Extracts query parser errors to dedicated files (includes mapper). Continuation of work done at the end of last year whilst waiting on other discussions to progress.

@AndrewSisley AndrewSisley added area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components action/no-benchmark Skips the action that runs the benchmark. labels Jan 16, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5 milestone Jan 16, 2023
@AndrewSisley AndrewSisley requested a review from a team January 16, 2023 20:18
@AndrewSisley AndrewSisley self-assigned this Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #1035 (17ab8ff) into develop (d87bae8) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1035   +/-   ##
========================================
  Coverage    57.74%   57.74%           
========================================
  Files          172      172           
  Lines        19484    19484           
========================================
  Hits         11252    11252           
  Misses        7238     7238           
  Partials       994      994
Impacted Files Coverage Δ
query/graphql/parser/filter.go 48.27% <0.00%> (ø)
query/graphql/parser/mutation.go 80.21% <0.00%> (ø)
query/graphql/parser/query.go 78.69% <0.00%> (ø)
query/graphql/parser/subscription.go 74.46% <0.00%> (ø)

shahzadlone
shahzadlone approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit 5175262 into develop Jan 16, 2023
@AndrewSisley AndrewSisley deleted the sisley/refactor/I257-mv-parser-errs branch January 16, 2023 21:36
shahzadlone pushed a commit that referenced this pull request Apr 13, 2023
@AndrewSisley @shahzadlone
refactor: Extract query parser errors to dedicated file (#1035)
fe72e71
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
refactor: Extract query parser errors to dedicated file (sourcenetwor…
ba3f316 
…k#1035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
action/no-benchmark Skips the action that runs the benchmark. area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewSisley @shahzadlone