Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Race condition having to do with search and SQL #5329

Closed
ijt opened this issue Aug 22, 2019 · 4 comments
Closed

Race condition having to do with search and SQL #5329

ijt opened this issue Aug 22, 2019 · 4 comments
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. good first issue Good for newcomers

Comments

@ijt
Copy link
Contributor

ijt commented Aug 22, 2019

I saw this race condition in the logs today:

Screen Shot 2019-08-21 at 10 03 33 PM

@ijt ijt added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. search labels Aug 22, 2019
@ijt ijt self-assigned this Aug 22, 2019
@nicksnyder nicksnyder added the good first issue Good for newcomers label Oct 14, 2019
@anukul
Copy link
Contributor

anukul commented Jul 31, 2020

Hi!

From the traceback, I found some related issues - golang/go#23519, lib/pq#706 and was able to reproduce the data race in general usage of lib/pq

image

It looks like lib/pq is not maintained any longer, but I can probably try to fix the problem by following an approach similar to the go-sql-driver/mysql#943 patch for this issue, if that is preferred over using another driver like pgx.

@unknwon
Copy link
Member

unknwon commented Aug 5, 2020

cc @sourcegraph/cloud ^ WDYT about changing lib/pg to pgx?

@asdine
Copy link
Contributor

asdine commented Aug 5, 2020

It seems like a good opportunity to switch to pgx 👍

@lguychard
Copy link
Contributor

This no longer appears to be relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants