Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Invalidate execution cache entries if secret value changes #42611

Closed
courier-new opened this issue Oct 6, 2022 · 2 comments
Closed

Invalidate execution cache entries if secret value changes #42611

courier-new opened this issue Oct 6, 2022 · 2 comments
Assignees
@eseliger
Labels
batch-changes Issues related to Batch Changes

Comments

@courier-new
Copy link
Contributor

courier-new commented Oct 6, 2022 •
edited
Loading

Follow up to https://github.com/sourcegraph/sourcegraph/issues/27926.

When a secret value that is referenced by a batch spec changes, we should automatically invalidate the cache for that batch spec execution.

This is effectively blocked by https://github.com/sourcegraph/sourcegraph/issues/41831 as it's very hard to do with the current parser.
@courier-new courier-new added the batch-changes Issues related to Batch Changes label Oct 6, 2022
This was referenced Oct 6, 2022
Closed
Open
@eseliger
Copy link
Member

eseliger commented Oct 6, 2022

Given the ticket that blocks this has been voted for backlog so far, this would have to follow that

@courier-new courier-new changed the title Invalidate execution cache entries if env variable or secret value changes Invalidate execution cache entries if secret value changes Oct 11, 2022
@eseliger
Copy link
Member

This will be supported by secrets V1!

@eseliger eseliger self-assigned this Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eseliger eseliger

Labels
batch-changes Issues related to Batch Changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrispine @courier-new @eseliger