Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

src-cli: Implement new campaigns workflow #12333

Closed
6 tasks
mrnugget opened this issue Jul 20, 2020 · 1 comment · Fixed by sourcegraph/src-cli#260
Closed
6 tasks

src-cli: Implement new campaigns workflow #12333

mrnugget opened this issue Jul 20, 2020 · 1 comment · Fixed by sourcegraph/src-cli#260
Assignees
Milestone

Comments

@mrnugget
Copy link
Contributor

mrnugget commented Jul 20, 2020

Docs/Schema in PR #10921

Tasks

  • Implement src campaigns apply (see this comment https://github.com/sourcegraph/sourcegraph/pull/10921#issuecomment-648599857)
  • Validate campaign spec YAML according to schema
    • I think duplicating that schema between here and src-cli is fine for now. If we can find a better solution that has src-cli fetch the schema from Sourcegraph: great.
  • Create changesetSpecs with the createChangesetSpec mutation (see schema here), remembering their IDs
  • Create campaignSpec, using the IDs as input
  • Print preview URL if user doesn't want to apply
  • Call applyCampaign if user wants to apply

Plus: clean up the code, possibly add tests, move code to smaller packages instead of the ./cmd folder, etc.

First deliverable

A draft PR that implements the new command and flow for us to test to validate how the UX feels.

@marekweb
Copy link
Contributor

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.19 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants