Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Resolving repo by clone URL fails in production with RepoLookup: {Repo: ExternalRepo:<nil>}: http status 500 #1166

Closed
felixfbecker opened this issue Nov 28, 2018 · 5 comments · Fixed by #1180
Assignees
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.

Comments

@felixfbecker
Copy link
Contributor Author

This is blocking sourcegraph/sourcegraph-typescript#8

@felixfbecker felixfbecker added the bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. label Nov 29, 2018
@nicksnyder
Copy link
Contributor

I don't anticipate having time to investigate this in the next 24 hours.

@emidoots
Copy link
Member

The trace indicates that reposource.CloneURLToRepoName(*args.CloneURL) is returning an empty string and no error.

The function does that when there are no registered repo sources in the configuration which can interpret the URL: https://sourcegraph.sgdev.org/github.com/sourcegraph/sourcegraph/-/blob/pkg/conf/reposource/common.go#L71

@beyang thoughts on the above since you wrote the package? what is a good solution here?

@felixfbecker warning: I will not have time to look into this further until at least Mon.

@felixfbecker
Copy link
Contributor Author

Thanks, I added a check for the empty string in https://github.com/sourcegraph/sourcegraph/commit/8821f9653a7c4959a3a93dff59853caa0b62ddaa, but it will not fix the issue of course.

So does prod not have configured "repo sources" for GitHub and Gitlab? @beyang

@beyang
Copy link
Member

beyang commented Nov 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior.
Projects
None yet
4 participants