Backend: New campaign flow

[eseliger]

Docs/Schema in PR #10921

STATUS: WIP pull request is https://github.com/sourcegraph/sourcegraph/pull/11675 and the tasks below as a WIP until we've done 3.19 planning.

Conceptual/Docs/GraphQL Schema

The PR in which these higher-level changes should be proposed/made/discussed is https://github.com/sourcegraph/sourcegraph/pull/10921

• Schema for tracking existing changesets in campaign-spec.yml

Implementation Backend

The list below is not complete, but a rough overview of what has been done and needs to be done:

• Pull in the GraphQL schema from https://github.com/sourcegraph/sourcegraph/pull/10921 as a skeleton (with only "TODOs" as implementation)
• Remove GraphQL resolvers and majority of campaigns.Service methods that were only used in old workflow (I decided to keep the type definitions and database tables for Patch/PatchSet/ChangesetJob around, even though I anticipate that we will need to remove them)
• Add campaign_specs & changeset_specs database tables, Go type definitions and methods in campaigns.Store
• Add CampaignSpecByID query and CampaignSpec resolver (some methods still have TODOs)
• Add ChangesetSpecByID query and ChangesetSpec resolver (some methods still have TODOs)
• Implement createChangesetSpec mutation
• Implement createCampaignSpec mutation
• Implement applyCampaignSpec
• Implement moveCampaign mutation
• Update the GraphQL API to reflect newest state in update docs for new campaign flow #10921
• Move fields from CampaignSpec.Spec to ChangesetSpec.Description after newest updates to update docs for new campaign flow #10921
• Validate CampaignSpec in (*Service).CreateCampaignSpec (depends on schema, see above)
• Validate ChangesetSpec in (*Service).CreateChangesetSpec (depends on schema, see above)
• Allow on: (unquoted!) in YAML definition of CampaignSpec
• Expire {Campaign,Changeset}Specs
  • Return proper value in {Campaign,Changeset} Spec.ExpiresAt
• Implement ChangesetSpec/CampaignSpec resolvers so that CampaignSpec.PreviewURL works
• In createCampaignSpec check the user has access to the namespace it's creating the spec for.
• In moveCampaign check the user has access to the new namespace.
• Implement Changeset.Status API
  • Add new state field to Changeset
  • Create "pending"/"unpublished" changesets when applying a CampaignSpec
    • Add internal state field to changesets
    • Add changeset_spec_id to changesets
  • ... many more things I have in a separate list
• Implement the Reconciler that picks up unreconciled campaigns and creates the desired state
• Implement tracking/importing of manual changesets

[uwedeportivo]

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.17 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

[daxmc99]

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.18 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

[mrnugget]

I'm closing this after merging https://github.com/sourcegraph/sourcegraph/pull/12435. What's left to do in the backend has been extracted into separate tickets:

• Implement the changesetsConnectionStatsResolver Implement the changesetsConnectionStatsResolver #12642
• Implement the "processing?" checks in CloseCampaign/DeleteCampaign Implement the "processing?" checks in CloseCampaign/DeleteCampaign #12643
• Move CloseOpenChangesets to the reconciler Move CloseOpenChangesets to the reconciler #12644
• Move SyncChangesets to the background Move SyncChangesets to the background #12645
• Implement missing methods in changesetResolver Implement missing methods in changesetResolver #12646
• Change testChangesetResponse in permissions_test.go to include publication status, error and reconciler state Change testChangesetResponse in permissions_test.go to include publication status, error and reconciler state #12647
• Replace commented-out portion of TestCampaigns in resolvers/resolver_test.go with more extensive test that tests ApplyCampaign Replace commented-out portion of TestCampaigns in resolvers/resolver_test.go with more extensive test that tests ApplyCampaign #12648
• Check that retrying of changeset create/update works correctly in reconciler Allow retrying of errored changesets #12700