JDK Standard Library Hovers #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
added
lib/com.sun.source
This was referenced Nov 13, 2020
efritz
reviewed
Nov 19, 2020
efritz
approved these changes
Nov 19, 2020
Strum355
changed the title
Turns out passing in an "empty" sourcefilemanager keeps the validator happy, which feels like a weird hack But it seems to work? And we dont really need a full file manager as we're only parsing, not analyzing. On that note, we're ditching analyzing. Even if the cost could be offset to making this whole spiel async, the failure rate was too high (to be investigated), and with some more manual work of equality checking, we should be able to get the same results for significantly cheaper and more "reliably"
As we no longer analyze deps, we dont get symbol info eg the owner symbol Hence we cant deduce what the owning class of a method is to avoid collision scenarios where a single comp unit has multiple identical methods or vars in different nested classes We work around this by having one DocExtractionVisitor per class decl, which holds the ClassTree ref for other visitor methods to reference to check what class we are in
Strum355
force-pushed
the
nsc/java-stdlib-hover
branch
from
eb612ff to
2586043
Compare
Strum355
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested for versions above 8.Please hold back all tears when reading JDK8CompatFileManager class