Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Intercepting of javac calls with gradle #78

Closed
wants to merge 1 commit into from

Conversation

Strum355
Copy link
Contributor

No description provided.

@Strum355 Strum355 added lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence labels Nov 12, 2020
@Strum355 Strum355 added this to the 3.22 milestone Nov 12, 2020
@Strum355 Strum355 requested a review from a team November 12, 2020 00:08
Copy link
Contributor

@efritz efritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you hate newlines at end of file?

@Strum355
Copy link
Contributor Author

Ruins symmetry with the first line, having a final empty one 😤 feels like an awkward appendage 👀

@olafurpg
Copy link
Member

Closing this as we're going with another approach as discussed offline. I will open a PR soon with the new approach.

@olafurpg olafurpg closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gradle project meta inference
3 participants