Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build meta from gradle init script #74

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Nov 4, 2020

Init script is derived from https://github.com/fwcd/kotlin-language-server/blob/master/server/src/main/resources/projectClassPathFinder.gradle

Will consider #70 closeable after merging this, further improvements can be made on an as-needed basis
Going to attempt similar to the following also https://kythe.io/examples/#extracting-gradle-based-repositories

From second commit:
Another best-effort attempt at deriving some build meta (classpaths) from gradle.
Has great results in some Android repos tested (airbnb/epoxy for one)
This approach could be used further for getting more comprehensive meta for other config but thus far source dir and java version inference has been good enough

As the gradle connector and models are accessed synchronously, we dont need the locking overhead
Another best-effort attempt at deriving some build meta (classpaths) from gradle.
Has great results in some Android repos tested (airbnb/epoxy for one)
This approach could be used further for getting more comprehensive meta for other config but thus far source dir and java version inference has been good enough
@Strum355 Strum355 added lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence labels Nov 4, 2020
@Strum355 Strum355 added this to the 3.22 milestone Nov 4, 2020
@Strum355 Strum355 requested a review from a team November 4, 2020 18:31
@Strum355 Strum355 linked an issue Nov 4, 2020 that may be closed by this pull request
@Strum355 Strum355 merged commit 9b0870d into nsc/comsunsource Nov 6, 2020
@Strum355 Strum355 deleted the nsc/gradle-initscript branch November 6, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gradle project meta inference
1 participant