Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gradle project meta inference #70

Closed
Strum355 opened this issue Oct 30, 2020 · 4 comments · Fixed by #74
Closed

Improve gradle project meta inference #70

Strum355 opened this issue Oct 30, 2020 · 4 comments · Fixed by #74
Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence type/enhancement New feature or request
Milestone
3.22

Comments

@Strum355
Copy link
Contributor

Currently importing as an EclipseProject model. Importing as an IdeaProject (preliminarily) appears to be better at providing dependencies locations (which are fed into the -classpath flag). More investigation needed, maybe results will be merged?
@Strum355 Strum355 added type/enhancement New feature or request lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence labels Oct 30, 2020
@Strum355 Strum355 added this to the 3.22 milestone Oct 30, 2020
@Strum355 Strum355 self-assigned this Oct 30, 2020
This was referenced Oct 30, 2020
Closed
Closed
@Strum355
Copy link
Contributor Author

IdeaProject model is less reliable for getting java source versions (requires the use of JavaVersion.XYZ), while EclipseProject parses string if provided e.g. "1.8"

@Strum355
Copy link
Contributor Author

Combining the discovered classpath/dependencies list appears to have a net positive effect on the number of javac errors. Still generally a large number of symbols and packages not resolved (looking at you, org.apache.thrift)

@Strum355 Strum355 mentioned this issue Nov 4, 2020
Merged
@Strum355 Strum355 linked a pull request Nov 4, 2020 that will close this issue
Build meta from gradle init script #74
Merged
@Strum355 Strum355 linked a pull request Nov 12, 2020 that will close this issue
WIP: Intercepting of javac calls with gradle #78
Closed
@Strum355
Copy link
Contributor Author

Exploring Kythe-style javac interception in #78
Has the unfortunate effect of requiring the entire build phase to be run (without gradle caching), but may be a necessary effect to get classpaths completely correct

@Strum355 Strum355 removed their assignment Feb 15, 2021
@Strum355
Copy link
Contributor Author

Closing for #87 , no longer relevant with new direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence type/enhancement New feature or request
Projects
None yet
Milestone
3.22
1 participant
@Strum355