Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle support #42

Closed
Strum355 opened this issue Sep 22, 2020 · 4 comments · Fixed by #63
Closed

Gradle support #42

Strum355 opened this issue Sep 22, 2020 · 4 comments · Fixed by #63
Assignees
@Strum355
Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence type/enhancement New feature or request
Milestone
3.22

Comments

@Strum355
Copy link
Contributor

Move away from getting users to have to generate a Maven project from a Gradle project with fiddly Groovy scripts. We demand native support 💢

Direction will be dependent on results of RFC 238
@Strum355 Strum355 added this to the 3.21 milestone Sep 22, 2020
@Strum355 Strum355 self-assigned this Sep 22, 2020
@Strum355 Strum355 modified the milestones: 3.21, 3.22 Oct 16, 2020
@Strum355 Strum355 added the type/enhancement New feature or request label Oct 16, 2020
@Strum355
Copy link
Contributor Author

For a first quick pass (without invoking gradle programmatically), consider: https://github.com/sourcegraph/java-langserver/blob/master/src/main/java/com/sourcegraph/langserver/langservice/gradle/Fradle.java

@Strum355 Strum355 changed the title Native Gradle support Gradle support Oct 16, 2020
@Strum355 Strum355 added lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence labels Oct 16, 2020
This was referenced Oct 16, 2020
Closed
Closed
@Strum355 Strum355 linked a pull request Oct 20, 2020 that will close this issue
First iteration of gradle: fetching of source directories and classpath #63
Merged
@Strum355
Copy link
Contributor Author

Went with Gradle Tooling API approach. Appears to work well for both single-project and multi-project gradle configurations 👍

Appears to not work in certain situations e.g. when java plugin is not in use. Oh well

@Strum355
Copy link
Contributor Author

Closing issue as it "works". Further tracking issues will be created for individual issues encountered as they occur

@aidaeology
Copy link
Contributor

@Strum355 Yay! Glad to see there's now native support for Gradle projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Strum355 Strum355

Labels
lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence type/enhancement New feature or request
Projects
None yet
Milestone
3.22
Development

Successfully merging a pull request may close this issue.

First iteration of gradle: fetching of source directories and classpath sourcegraph/scip-java
2 participants
@aidaeology @Strum355