Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

remote implementations are not linked for method calls #208

Open
tjdevries opened this issue Nov 4, 2021 · 0 comments
Open

remote implementations are not linked for method calls #208

tjdevries opened this issue Nov 4, 2021 · 0 comments
Assignees

Comments

@tjdevries
Copy link
Contributor

tjdevries commented Nov 4, 2021

I'll probably work on this next, but it is not a blocking issue to ship implementations, IMO

Some example tests:

	t.Run("remote_implementations: finuds implementations in signature", func(t *testing.T) {
		r := mustRange(t, w, "file://"+filepath.Join(projectRoot, "implementations_remote.go"), 10, 38)

		monikers := findMonikersByRangeOrReferenceResultID(w, r.ID)
		t.Fatalf("%+v\n", monikers)
	})

	t.Run("remote_implementations: finds implementations on method call", func(t *testing.T) {
		r := mustRange(t, w, "file://"+filepath.Join(projectRoot, "implementations_remote.go"), 11, 12)

		// assertRanges(
		// 	t,
		// 	w,
		// 	findImplementationRangesByRangeOrResultSetID(w, r.ID),
		// 	[]string{"4:5-4:21"},
		// 	"ResponseWriter Implementation (from signature)",
		// )

		monikers := findMonikersByRangeOrReferenceResultID(w, r.ID)
		t.Fatalf("%+v\n", monikers)
	})
@tjdevries tjdevries self-assigned this Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant