New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string IDs #1

Closed

sqs opened this issue Nov 1, 2016 · 1 comment

Member

sqs commented Nov 1, 2016

According to JSON-RPC 2.0 spec, Request ID may contain string, number or NULL http://www.jsonrpc.org/specification#request_object but in https://github.com/sourcegraph/jsonrpc2/blob/master/jsonrpc2.go#L42 ID is only uint64.

Reported by @evidolob

Member Author

sqs commented Nov 6, 2016

Fixed in #2

sqs closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment