Skip to content
This repository has been archived by the owner on Feb 21, 2025. It is now read-only.

E2E test coverage for GA, GTM, and third party scripts #5494

Merged
merged 5 commits into from
Jun 17, 2022
Merged

Conversation

bretthayes
Copy link
Contributor

This closes #5460 and integrates a GitHub workflow and e2e test to ensure our GA, GTM, and third party scripts are rendered and working correctly.

Test

  1. Ensure prettier has standardized the proposed changes.

Verified

This commit was signed with the committer’s verified signature.
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jun 17, 2022

Notifying subscribers in CODENOTIFY files for diff 1bb427b...952bad2.

Notify File(s)
@content-platform-team .github/workflows/tests.yml
.gitignore
README.md
cypress.config.ts
cypress/e2e/scripts.test.ts
cypress/plugins/index.js
cypress/support/e2e.ts
cypress/tsconfig.json
package.json
src/pages/_app.tsx
tsconfig.json
yarn.lock

@bretthayes bretthayes requested a review from st0nebreaker June 17, 2022 14:37
Copy link
Contributor

@zlonko zlonko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really looking forward to having this end to end coverage. A quick TS observation, and a note that Prettier suggested a few changes.

st0nebreaker
st0nebreaker previously approved these changes Jun 17, 2022
Copy link
Contributor

@st0nebreaker st0nebreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Is the new expectation to bring in unit testing in Cypress? Curious what our test coverage plan will be now moving forward.

Also can we add documentation to the README around our tests now that they're brought in? Which command to run locally before pushing up, and such?

I haven't done testing with Cypress yet, so I'm excited to dive into it 🧪 I used jest, mocha/chai, and react testing library before. Using them first with our 3rd party scripts is clutch 💪🏻

@bretthayes
Copy link
Contributor Author

Just updated prettier @zlonko, and added a note in the our readme for how to create and run our e2e tests @st0nebraker 🤓 Should be good to go now!

@bretthayes
Copy link
Contributor Author

Btw @st0nebraker, as far as expectations go, I think if we find areas to test critical parts of the app, we should add them for stability, reassurance and automated QA. 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Confirm analytics is working correctly with an integration test
4 participants