-
Notifications
You must be signed in to change notification settings - Fork 173
E2E test coverage for GA, GTM, and third party scripts #5494
Conversation
Notifying subscribers in CODENOTIFY files for diff 1bb427b...952bad2.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really looking forward to having this end to end coverage. A quick TS observation, and a note that Prettier suggested a few changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Is the new expectation to bring in unit testing in Cypress? Curious what our test coverage plan will be now moving forward.
Also can we add documentation to the README around our tests now that they're brought in? Which command to run locally before pushing up, and such?
I haven't done testing with Cypress yet, so I'm excited to dive into it 🧪 I used jest, mocha/chai, and react testing library before. Using them first with our 3rd party scripts is clutch 💪🏻
Just updated prettier @zlonko, and added a note in the our readme for how to create and run our e2e tests @st0nebraker 🤓 Should be good to go now! |
Btw @st0nebraker, as far as expectations go, I think if we find areas to test critical parts of the app, we should add them for stability, reassurance and automated QA. 🙂 |
This closes #5460 and integrates a GitHub workflow and e2e test to ensure our GA, GTM, and third party scripts are rendered and working correctly.
Test