Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe copy should not ignore gitignore patterns by default #454

Open
sourcefrog opened this issue Nov 22, 2024 · 0 comments
Open

Maybe copy should not ignore gitignore patterns by default #454

sourcefrog opened this issue Nov 22, 2024 · 0 comments
Labels
copy_tree Copying trees to build dirs

Comments

@sourcefrog
Copy link
Owner

people might be using the "ignored but added" pattern even inside their source tree, and so using it while copying would make an unusable copy. Maybe using gitignores isn't a good default.

Originally posted by @sourcefrog in #450 (comment)

There is already an option for this, but it defaults to on.

https://github.com/sourcefrog/cargo-mutants/blob/main/src/main.rs#L189-L192

Probably, the main thing we care about is to not copy /target by default, because that might be large and often the contents can't be reused. However, we have a separate option for this: currently deprecated, but it could be un-deprecated:

cargo-mutants/src/main.rs

Lines 259 to 262 in c8d09ab

/// Don't copy the /target directory, and don't build the source tree first.
#[arg(long, help_heading = "Copying", group = "copy_opts")]
no_copy_target: bool,

@sourcefrog sourcefrog added the copy_tree Copying trees to build dirs label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copy_tree Copying trees to build dirs
Projects
None yet
Development

No branches or pull requests

1 participant