Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hash Displayed on Failure is Confusing: Hash Expected? or Hash Found? #180

Open
DiagonalArg opened this issue Nov 15, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@DiagonalArg
Copy link

It's confusing to have the hash found, rather than the hash expected, presented on output when a check fails. Going to check the key of the package reveals the hash to match, which leads to head scratching. Perhaps you might output: Hash Expected and Hash Found? Or even just "Expected: xx:xx:xx:xx"

@soupslurpr
Copy link
Owner

it's not. apps can have multiple versions that are signed with different keys but with the same variant so this wouldn't really work well anyways

@soupslurpr soupslurpr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
@DiagonalArg
Copy link
Author

Perhaps a list of those variants that were checked, in smaller type? eg:

Found: xx:xx:xx...

Expected one of:
yy:yy:yy
zz:zz:zz

@soupslurpr
Copy link
Owner

Okay, but what is this useful for?

@DiagonalArg
Copy link
Author

Okay, but what is this useful for?

First of all, it eliminates confusion. When there's a failure (as in the image below) and that hash comes up, it's not clear if that's the hash of the package I just checked, or the hash that AppVerifier thinks I should have.

Second, if I know what hash AppVerifier may be expecting, I might be able to work out the issues; does AppVerifier have the wrong hash? am I checking the wrong package?

image

@soupslurpr
Copy link
Owner

soupslurpr commented Nov 15, 2024

perhaps that could be added in the failure info or something. I don't think I'm going to work on this myself though.

@soupslurpr soupslurpr reopened this Nov 15, 2024
@soupslurpr soupslurpr added the enhancement New feature or request label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants