Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start the setup process start in the language that the iPhone is set to #112

Open
jchudge opened this issue Oct 9, 2024 · 3 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jchudge
Copy link

jchudge commented Oct 9, 2024

Based on user feedback

The current version of Soundscape starts the setup process in English when the app is first installed.
Then the user could change the language in the middle of the setup.
I'd like to have the setup process start in the language that the iPhone is set to, but I feel that the language question to choose another language should not be eliminated in case the user is bilingual.
The app should default to English only if the phone is already set to English or if the iPhone is set to a language not supported by Soundscape.

Also, the Soundscape Language screen is missing from the U.S. English version of the App Setup in the help documentation but it's there in the U.K. English version.

@jchudge jchudge added bug Something isn't working good first issue Good for newcomers labels Oct 9, 2024
@ryanThomas21
Copy link
Contributor

I'll look into this

@ryanThomas21
Copy link
Contributor

ryanThomas21 commented Oct 25, 2024

It seems like depending on the types of languages the user chooses the language won't update. This may be because of the region the languages are from and whether or not those specific types of a certain language are in our list of languages. For example if I put Spanish U.S. as my default language in the simulator, this won't be picked up and will start the app in english. However, if I use Spanish (Spain) it will change the startup language.

@steinbro
Copy link
Member

steinbro commented Oct 26, 2024

Here's the logic that sometimes skips the language selection during app setup:

if LocalizationContext.deviceLocale.identifierHyphened == LocalizationContext.currentAppLocale.identifierHyphened {
OnboardingHeadphoneView()
} else {
OnboardingLanguageView()
}

So the user is presented with language selection only if the device locale and app locale don't match. I'm not sure what that means in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants