Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect handling of ".include" in identifiers #2498

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Mingtao521
Copy link
Contributor

Souffle's lexer incorrectly recognizes ".include" as a keyword or directive, rather than part of an identifier.

Updated scanner.ll to ensure ".include" is only treated as a directive when followed by whitespace.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (b82ae20) to head (9ce1be3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2498      +/-   ##
==========================================
- Coverage   81.11%   81.06%   -0.05%     
==========================================
  Files         492      492              
  Lines       30922    30922              
==========================================
- Hits        25082    25067      -15     
- Misses       5840     5855      +15     
Files Coverage Δ
src/parser/scanner.ll 81.53% <100.00%> (ø)

... and 5 files with indirect coverage changes

@quentin quentin merged commit e6cc668 into souffle-lang:master Jul 3, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants