Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse CSV QualifiedNames instead of just Identifier for ADTs #2358

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

bmeck
Copy link
Contributor

@bmeck bmeck commented Nov 8, 2022

fixes #2349 for CSV files, does not add support for ADTs to SQLite or JSON.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #2358 (3047414) into master (e5549a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2358   +/-   ##
=======================================
  Coverage   77.43%   77.43%           
=======================================
  Files         470      470           
  Lines       29339    29332    -7     
=======================================
- Hits        22718    22713    -5     
+ Misses       6621     6619    -2     
Impacted Files Coverage Δ
src/ast/transform/ExecutionPlanChecker.cpp 100.00% <100.00%> (ø)
src/include/souffle/io/ReadStream.h 86.52% <100.00%> (ø)
src/main.cpp 69.21% <0.00%> (-0.55%) ⬇️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 88.80% <0.00%> (+1.59%) ⬆️

Copy link
Member

@quentin quentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the contribution.

@quentin quentin merged commit a11d23e into souffle-lang:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component ADTs cannot round trip through .input and .output even with rfc4180=true
2 participants