Japanese translation: Beware division by zero #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sot528
reviewed
Nov 9, 2017
README-ja.md
Outdated
|
|
||
| Prior to version 0.4, Solidity [returns zero](https://github.com/ethereum/solidity/issues/670) and does not `throw` an exception when a number is divided by zero. Ensure you're running at least version 0.4. | ||
| 0.4より前のバージョンでは、Solidityはゼロを返し、数値をゼロで割ったときに例外をスローしません。 |
There was a problem hiding this comment.
returns zero に貼られているリンクも付加できればと感じました。
また文脈的に↓のような訳が自然かなと感じました。
0.4より前のバージョンでは、数値をゼロで割ったときにSolidityはゼロを返し、例外をスローしません。
|
@sot528 レビューありがとうございます! 修正しました 😄 |
|
LGTM! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sot528
Beware division by zeroを日本語訳しました!該当箇所
https://github.com/sot528/smart-contract-best-practices/blob/master/README-ja.md#beware-division-by-zero-solidity--04