Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dec98_9 roll tests with new guide counts #219

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

jeanconn
Copy link
Contributor

Description

Update dec98_9 roll tests with new guide counts.

I'm still a little unclear about why these tests are failing now - it would seem to speak to a problem with the test setup with either of the PRs related to dyn_bgd_n_faint in sparkles. But still seems benign.

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-latest) flame:sparkles jean$ python -c "import proseco; print(proseco.__version__)"
5.15.1.dev6+g23db6ec
(ska3-flight-latest) flame:sparkles jean$ git rev-parse HEAD
403c8be5ab51c260769eaafecec344c34a6c6c39
(ska3-flight-latest) flame:sparkles jean$ pytest
======================================================================= test session starts =======================================================================
platform darwin -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
PyQt5 5.15.9 -- Qt runtime 5.15.8 -- Qt compiled 5.15.8
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: astropy-0.11.0, qt-4.4.0, cov-5.0.0, timeout-2.2.0, remotedata-0.4.1, anyio-4.3.0, filter-subpackage-0.2.0, doctestplus-1.2.1, astropy-header-0.2.2, hypothesis-6.112.0, arraydiff-0.6.1, mock-3.14.0
collected 104 items                                                                                                                                               

sparkles/tests/test_checks.py ............................................................................                                                  [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                                                [ 77%]
sparkles/tests/test_review.py ...................                                                                                                           [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                                           [100%]

====================================================================== 104 passed in 30.01s

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@jeanconn jeanconn merged commit 6814f65 into master Nov 26, 2024
2 checks passed
@jeanconn jeanconn deleted the fix-roll-test branch November 26, 2024 17:17
@javierggt javierggt mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants