Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sparkles tests for proseco no-color1 guide star change #212

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Oct 9, 2024

Description

Update sparkles tests for proseco no-color1 guide star change (sot/proseco#401)

Interface impacts

Testing

Tested in ska3-masters environment with sot/proseco#401

Unit tests

  • Mac
(ska3-flight-latest) flame:sparkles jean$ git rev-parse HEAD
56cad16c648ed8674c6527bb0ea010ea23e77a28
(ska3-flight-latest) flame:sparkles jean$ pytest
========================================================================== test session starts ===========================================================================
platform darwin -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
PyQt5 5.15.9 -- Qt runtime 5.15.8 -- Qt compiled 5.15.8
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: astropy-0.11.0, qt-4.4.0, cov-5.0.0, timeout-2.2.0, remotedata-0.4.1, anyio-4.3.0, filter-subpackage-0.2.0, doctestplus-1.2.1, astropy-header-0.2.2, hypothesis-6.112.0, arraydiff-0.6.1, mock-3.14.0
collected 103 items                                                                                                                                                      

sparkles/tests/test_checks.py ............................................................................                                                         [ 73%]
sparkles/tests/test_find_er_catalog.py .....                                                                                                                       [ 78%]
sparkles/tests/test_review.py ..................                                                                                                                   [ 96%]
sparkles/tests/test_yoshi.py ....                                                                                                                                  [100%]

========================================================================== 103 passed in 29.18s

Independent check of unit tests by [REVIEWER NAME]

  • OSX
  • Linux

Functional tests

No functional testing.

@jeanconn jeanconn merged commit 68b10f1 into master Oct 15, 2024
2 checks passed
@jeanconn jeanconn deleted the proseco-nocolor-test branch October 15, 2024 13:39
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants