-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fot-matlab tests #73
Comments
@jskrist I think it would make sense for us to run the fot-matlab unit tests as part of ska3 integration runs, but I note that the test_stars.test_one_obs test fails for me now. Might make sense to work together to pin the data used in star selection so that test stays relatively stable. |
@jeanconn I recently made some commits to update the tests, and I did find that the test you mentioned needs an environment variable set to run properly for me in Windows. Not sure if that is the same issue you ran into or not. So, yes, let's work together to pin something down for testing. |
Thanks @jskrist! For star selection, there is the issue that there is a lot of data that is being updated all the time that is used. So we have the same issue that you have in general on the matlab side about what to do for regression-type tests. For a lot of our star selection tests we've moved to using env vars to configure things such that:
From the test-runner side, we've been using monkeypatch.setenv to set the env vars in the tests. However, for this test in fot-matlab we'd also need to have the star selection used to create the reference data pkl use the same setup. |
Add the fot-matlab unit tests
The text was updated successfully, but these errors were encountered: