-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MAUDE telemetry for events #343
base: master
Are you sure you want to change the base?
Conversation
This changes the logic for TlmEvent models to check for an existing model in the database by tstart, not just primary key.
Few questions:
One comment: |
See the sync_ska_data_occ repo, which includes a call to
I think there is a disconnect. The cheta data archive is specifically unrelated to this PR since the idea is to use MAUDE instead.
I've been planning on something equivalent, which is to not do the kadi events update at all (even for non-telemetry events) if there is no new telemetry since the last update. In that way the script can kick off every hour, but only about 1 in 8 times does it actually end up updating My biggest concern is what happens to a client application that is accessing the database while the file gets updated. One option that would be a possibility with this PR is to actually run the update process on GRETA as well since it has access to MAUDE. My main concern there is reduced visibility into processing problems.
Agreed, I updated the description. |
Thanks Tom! "I think there is a disconnect" yeah - I immediately went to "what if we were updating the cxc cheta archive based on nrt maude" which is explicitly not what you are doing with this kadi PR. Sorry! I suppose the better question is if the there are any differences between data sources such as timing that will cause us any confusion in the future with the events. |
I just did some experiments on chimchim with updating the Which is to say that the linux kernel / NFS do interesting things and may protect us from problems related to rsync'ing while people are working. |
There will be differences in timing of up to 1/2 the sample period, so e.g. up to 1/2 second for maneuver event times. In practice this doesn't matter since we already have that disconnect between MAUDE/GRETA and CXC times all over the place. Going forward, using MAUDE times will probably be less confusing for FOT engineers. |
Right, the "does it matters if the the file updates while the user is working" question is also important. My long running cron jobs would still crash if the kadi events changed while the job was running (such that if working on head I usually made a local events copy) but that seems inconsistent with your testing just now. |
Description
Support using MAUDE as the source of telemetry for kadi events. This has been a long-standing request from FOT engineering and will allow the events to be up to date with ground telemetry soon after MAUDE dump data ingest completes.
In order to realize this reduction in latency, we need to change a couple of things in ground processing:
Interface impacts
No interface impact.
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
In both cases confirm that the test database matches the flight database (modulo expected small timing differences).