-
Notifications
You must be signed in to change notification settings - Fork 1
Discontinue support for chandra_cmd_states #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs workflow will fail, so we will need to make it and commit it by hand.
message_error = ( | ||
"\n" | ||
"To temporarily continue using this package set the environment variable\n" | ||
"SKA_ALLOW_DISCONTINUED_PACKAGES=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Picking nits, I think that's SKA_ALLOW_DISCONTINUED_PACKAGES='1'. but I'm good!
Oops, I approved the wrong one. But I'll re-approve this one soon. |
For this one, looking over code that might still use Chandra.cmd_states - what is the status of pyger and spaceweather repos? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporarily changing back my review status
Both pyger and spaceweather are not used in any production workflows and can be fixed as needed. I think pyger is no longer maintained or used. Spaceweather is my repo and I'll swap in kadi states as needed. |
Description
This addresses one action in sot/kadi#230.
Interface impacts
Importing package raises an exception unless
SKA_ALLOW_DISCONTINUED_PACKAGES=1
.Testing
Unit tests
No testing required for discontinued package.
Functional tests
Importing package fails without env var
Setting env var allows import with a FutureWarning